Two Buttons in DialogFooter #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be reused in a new Footer component. Also the padding is adjusted to match left-button/dialog-margin distance to right-button/dialog-margin distance.
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
=========================================
+ Coverage 13.47% 13.5% +0.03%
=========================================
Files 821 822 +1
Lines 26641 26640 -1
Branches 5618 5620 +2
=========================================
+ Hits 3590 3598 +8
+ Misses 21599 21590 -9
Partials 1452 1452
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both buttons can be titled and given handlers independently.
Default title for the left button is "Cancel".
Loading indicator only on right button.